Skip to content

fix: accept symbol feature flag keys#147

Merged
dustinbyrne merged 2 commits into
mainfrom
fix/flag-symbol-keys
May 13, 2026
Merged

fix: accept symbol feature flag keys#147
dustinbyrne merged 2 commits into
mainfrom
fix/flag-symbol-keys

Conversation

@dustinbyrne
Copy link
Copy Markdown
Contributor

💡 Motivation and Context

Feature flag APIs should accept Ruby symbols for flag keys as well as strings. Previously, symbol keys could miss local and remote flag lookups because SDK internals compared them directly against string keys.

This normalizes flag keys to strings across the flag APIs, including legacy single-flag methods, remote config payloads, and evaluate_flags(flag_keys:).

Review loop: checked the SDK diff against compatibility, API surface, entry-point tracing, performance, coverage, and error-handling criteria; no follow-up fixes were needed after the review.

💚 How did you test it?

  • bundle exec rspec
  • bundle exec rubocop

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran pnpm changeset to generate a changeset file

@dustinbyrne dustinbyrne requested a review from a team as a code owner May 12, 2026 14:12
Comment thread lib/posthog/client.rb
@dustinbyrne dustinbyrne force-pushed the fix/flag-symbol-keys branch from c85b703 to c9c3778 Compare May 12, 2026 20:38
@dustinbyrne dustinbyrne merged commit 4b3c2a8 into main May 13, 2026
14 checks passed
@dustinbyrne dustinbyrne deleted the fix/flag-symbol-keys branch May 13, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants